[PM-11405] Account Management: Prevent a verified user from changing their email address #4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rifiedUserEmailDomainAsync and refactor to return a list. Remove ManagedByOrganizationId from ProfileResponseMode. Add ManagesActiveUser to ProfileOrganizationResponseModel
…ing their email address
r-tome
changed the base branch from
main
to
ac/pm-11404/prevent-a-verified-user-from-purging-their-vault
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4875 +/- ##
==========================================
+ Coverage 42.47% 42.55% +0.08%
==========================================
Files 1386 1386
Lines 64625 64633 +8
Branches 5931 5933 +2
==========================================
+ Hits 27449 27506 +57
+ Misses 35952 35903 -49
Partials 1224 1224 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
…sManagedByAnyOrganizationAsync to not return nullable objects. Update ProfileOrganizationResponseModel.UserIsManagedByOrganization to not be nullable
…vault' into ac/pm-11405/prevent-a-verified-user-from-changing-their-email-address
r-tome
changed the title
…vault' into ac/pm-11405/prevent-a-verified-user-from-changing-their-email-address
Base automatically changed from
ac/pm-11404/prevent-a-verified-user-from-purging-their-vault
to
main
October 17, 2024 15:06
…nging-their-email-address
…piApplicationFactory to be able to enable specific features for each test
…t it on AccountsControllerTest
eliykat
reviewed
Oct 25, 2024
eliykat
approved these changes
Oct 28, 2024
JaredSnider-Bitwarden
approved these changes
Oct 28, 2024
…nging-their-email-address
r-tome
deleted the
ac/pm-11405/prevent-a-verified-user-from-changing-their-email-address
branch
cyprain-okeke
pushed a commit
that referenced
this pull request
Oct 30, 2024
…their email address (#4875) * Add check for managed user before purging account * Rename IOrganizationRepository.GetByClaimedUserDomainAsync to GetByVerifiedUserEmailDomainAsync and refactor to return a list. Remove ManagedByOrganizationId from ProfileResponseMode. Add ManagesActiveUser to ProfileOrganizationResponseModel * Rename the property ManagesActiveUser to UserIsManagedByOrganization * Remove whole class #nullable enable and add it to specific places * [PM-11405] Account Deprovisioning: Prevent a verified user from changing their email address * Remove unnecessary .ToList() * Refactor IUserService methods GetOrganizationsManagingUserAsync and IsManagedByAnyOrganizationAsync to not return nullable objects. Update ProfileOrganizationResponseModel.UserIsManagedByOrganization to not be nullable * Update error message when unable to purge vault for managed account * Update error message when unable to change email for managed account * Update expected error messages on unit tests * Add TestFeatureService to Api.IntegrationTest.Helpers and use it on ApiApplicationFactory to be able to enable specific features for each test * Add CreateVerifiedDomainAsync method to OrganizationTestHelpers * Add tests to AccountsControllerTest to prevent changing email for managed accounts * Remove setting the feature flag value in ApiApplicationFactory and set it on AccountsControllerTest * Remove TestFeatureService class from Api.IntegrationTest.Helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11405
📔 Objective
If the Account Deprovisioning feature flag is enabled and the user is managed by an organization then block the Change Email endpoints.
Clients PR: bitwarden/clients#11486
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes